RFR: 8338023: Support two vector selectFrom API [v7]

[Emanuel Peter]

On Fri, 30 Aug 2024 14:44:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding descriptive comments
>
> src/hotspot/share/opto/vectornode.cpp line 2104:
> 
>> 2102:   //         MASK)
>> 2103:   // This shall prevent an intrinsification failure and associated argument
>> 2104:   // boxing penalties.
> 
> A quick comment about how the mask is computed could be nice.
> `MASK = INDEX < num_elem`

@jatin-bhateja very nice, thanks!

> src/hotspot/share/opto/vectornode.cpp line 2148:
> 
>> 2146: 
>> 2147:   BoolTest::mask pred = BoolTest::lt;
>> 2148:   ConINode* pred_node = (ConINode*)phase->makecon(TypeInt::make(pred));
> 
> Would `as_ConI()` be a better alternative to the `(ConINode*)` cast?

Please at least add a comment why you are not following my suggestion. I feel like the work I put in to review is not being respected when comments are just silently resolved without any action or comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1760673419
PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1760656304