RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v5]
Emanuel Peter
epeter at openjdk.org
Mon Sep 16 13:00:14 UTC 2024
On Mon, 16 Sep 2024 08:43:42 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 41:
>>
>>> 39: import java.util.List;
>>> 40:
>>> 41: public class CompileFramework {
>>
>> General comment here: I suggest to add Javadocs to the public API methods in this class that the user can call.
>
> You should probably add a class comment since this is the main entry class/entry point to use the framework. Maybe give a short concise summary of what it does. More details can still be found in the README.
Will do!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1761095049
More information about the hotspot-compiler-dev
mailing list