RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v2]

[Emanuel Peter]

On Mon, 16 Sep 2024 06:38:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 53 additional commits since the last revision:
>> 
>>  - Merge branch 'fuzzer-test' of https://github.com/eme64/jdk into fuzzer-test
>>  - fix paths for windows, had compile issue
>>  - increase compile timeut
>>  - rm unnecessary test
>>  - Merge branch 'master' into fuzzer-test
>>  - Merge branch 'master' into fuzzer-test
>>  - Merge branch 'master' into fuzzer-test
>>  - name timeout better
>>  - stub of TestMergeStoresFuzzer
>>  - private source and classes directory per CompileFramework
>>  - ... and 43 more: https://git.openjdk.org/jdk/compare/51a90e3f...efe94764
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 54:
> 
>> 52:                     File.pathSeparator +
>> 53:                     classesDir.toAbsolutePath().toString();
>> 54:         return cp.replace("\\", "\\\\"); // For windows paths
> 
> Is this really required and not automatically handled correctly by `Path` on Windows?

I could also add this at the use-site. The problem is that I'm using it in the generated Java code as a String, and so there we have to escape the backslash. Without this, I got those mysterious timeouts on Windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1760811842