RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v11]

[Emanuel Peter]

On Mon, 16 Sep 2024 08:33:29 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   even more documentation
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 292:
> 
>> 290:         if (method == null) {
>> 291:             throw new CompileFrameworkException("Method \"" + methodName + "\" not found in class \n" + className + "\".");
>> 292:         }
> 
> Could be extracted to a method which returns a non-null method object (i.e. `findMethod()`) or something like that.

done.

> test/hotspot/jtreg/compiler/lib/compile_framework/SourceCode.java line 29:
> 
>> 27:  * This class represents the source code of a specific class.
>> 28:  */
>> 29: public class SourceCode {
> 
> I'm wondering if this class even needs to be exposed? AFAICS, you always do:
> 
> compileFramework.add(SourceCode.newJava/JasmSourceCode());
> ``` 
> This raises the question if you should just directly provide a `addJava/JasmSourceCode()` API method in `CompileFramework`?

changed it accordingly!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1761326918
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1761327821