RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

Emanuel Peter epeter at openjdk.org
Mon Sep 16 15:12:33 UTC 2024


On Mon, 16 Sep 2024 08:46:55 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> The framework is a very nice idea! It will definitely improve our testing coverage. It seems simple to use and also easier to review instead of having the fully generated test files to go through.
> 
> I did a first pass and left some comments.
> 
> Should we also add a `README.md`? You could add good the introduction and motivation in the PR summary to it. Additionally, you can mention the core features, reference your examples, give hints how the JTreg header comment should look like, and also add a section for future work if there is anything you think should/could be explored (not a conclusive list, just a few ideas what you could mention in the `README` :-) )

@chhagedorn thanks a lot for the review! I did some deep refactoring, and now I hope it is more to your liking ;)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20184#issuecomment-2353199644


More information about the hotspot-compiler-dev mailing list