RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

Emanuel Peter epeter at openjdk.org
Tue Sep 17 16:37:11 UTC 2024


On Tue, 17 Sep 2024 08:08:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 33:
> 
>> 31: 
>> 32: /**
>> 33: * This is the entry-point for the Compile Framework. Its purpose it to allow
> 
> General comment about Javadocs. I think the convention is the indent to the first `*`:
> 
> Suggestion:
> 
> /**
>  * This is the entry-point for the Compile Framework. Its purpose it to allow

ok, will fix it!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1763551405


More information about the hotspot-compiler-dev mailing list