RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

[Emanuel Peter]

On Tue, 17 Sep 2024 07:51:13 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 57:
> 
>> 55:     public void addJasmSourceCode(String className, String code) {
>> 56:         jasmSources.add(new SourceCode(className, "jasm", code));
>> 57:     }
> 
> Since this is the public API that the user should use, I suggest to also add a parameter description for all public API methods in this class with `@param` for completeness. Something like:
> 
>     /**
>      * Add a Jasm source to the compilation.
>      * 
>      * @param className The class name of the Jasm class.
>      * @param code      The source code of the Jasm class as string.
>      */
> 
> which renders to:
> 
> ![image](https://github.com/user-attachments/assets/4f0ba893-7876-4f57-b6ea-816f7e7660cd)

Ok, I'll do that :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1763564199