RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]
Emanuel Peter
epeter at openjdk.org
Wed Sep 18 06:53:44 UTC 2024
On Tue, 17 Sep 2024 08:51:55 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> move some code around
>
> test/hotspot/jtreg/compiler/lib/compile_framework/README.md line 31:
>
>> 29: ### Creating a new Compile Framework Instance
>> 30:
>> 31: First, one must create a `new CompileFramework()`, which creates two directories: a sources and a classes directory. The sources directory is where all the sources are placed by the Compile Framework, and the classes directory is where all the compiled classes are placed by the Compile Framework.
>
> You could add here that this is a fixed-named directory created inside the JTreg scratch directory. You can also add a link to the actual name where this is created inside `CompileFramework`.
Added your offline suggestion:
`First, one must create a `new CompileFramework()`, which creates two directories: a sources and a classes directory (see `sourcesDir` and `classesDir` in [CompileFramework](./CompileFramework.java))`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1764496476
More information about the hotspot-compiler-dev
mailing list