RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

[Emanuel Peter]

On Tue, 17 Sep 2024 09:14:56 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> Thanks for the updates - already looks much better! Some more comments.

@chhagedorn thanks a lot for the second round of review! I finally learned how to to Javadocs, and how to compile without IDE:

`jdk-fork2/open/test/hotspot/jtreg$ javadoc -sourcepath . -d ./docs -subpackages compiler.lib.compile_framework`

> test/hotspot/jtreg/testlibrary_tests/compile_framework/examples/TestFrameworkJavaExample.java line 49:
> 
>> 47:  * classes (see {@code getEscapedClassPathOfCompiledClasses}).
>> 48:  */
>> 49: public class TestFrameworkJavaExample {
> 
> Suggestion: This might be better named `IRFrameworkJavaExample`. It is a little bit unfortunate that I named the IR Framework main class `TestFramework` and not `IRFramework`...but I guess it's too late for that now.

Yeah, unfortunate 😅

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20184#issuecomment-2356513651
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1763620758