RFR: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option [v2]

[Doug Simon]

On Mon, 23 Sep 2024 07:34:32 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> I see, `FLAG_SET_DEFAULT(EnableJVMCI, true)` on [line 99](https://github.com/openjdk/jdk/blob/78f576192e815f957db93f5f8cb3763a35474381/src/hotspot/share/jvmci/jvmci_globals.cpp#L99).
>> Maybe moving this block 
>> 
>> if (!FLAG_IS_DEFAULT(EnableJVMCI) && !EnableJVMCI) {
>>       jio_fprintf(defaultStream::error_stream(),
>>           "Improperly specified VM option UseJVMCICompiler: EnableJVMCI cannot be disabled\n");
>>       return false;
>>     }
>>     FLAG_SET_DEFAULT(EnableJVMCI, true);
>> 
>> in front of my change  makes it more readable.
>
> It's not obvious to me how that's clearer than just expanding the guard on line 82 to be `EnableJVMCI || UseJVMCICompiler`.

Now that I see your change and understand what you meant, it is better - thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21069#discussion_r1770898087