RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v5]

Tue Apr 1 17:38:30 UTC 2025

On Thu, 27 Mar 2025 13:14:39 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments resolution
>
> I have not looked at the x64 instructions, but only the tests again.
> 
> I have noticed that you only cover specific values. You could improve tests with this:
> - Add non-canonical NaN values.
> - Just iterate over all possible Float16 input pairs. It's onls `2^32`, that should be feasible! Then compare compiled vs interpreted results.
> 
> It seems that bugs like these happen because somehow we do not systematically cover all inputs. Maybe we should do the same for all Float16 operations?

@eme64 We are looking forward to your approval for this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24169#issuecomment-2770211207