RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v5]

Wed Apr 2 06:34:32 UTC 2025

On Fri, 28 Mar 2025 04:50:17 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> I have not looked at the x64 instructions, but only the tests again.
>> 
>> I have noticed that you only cover specific values. You could improve tests with this:
>> - Add non-canonical NaN values.
>> - Just iterate over all possible Float16 input pairs. It's onls `2^32`, that should be feasible! Then compare compiled vs interpreted results.
>> 
>> It seems that bugs like these happen because somehow we do not systematically cover all inputs. Maybe we should do the same for all Float16 operations?
>
> Hi @eme64 ,
> This specific issues is around special Float16 values i.e  +/- 0.0 and NaN.
> I have added a Generator for Float16 as part of https://github.com/openjdk/jdk/pull/22755
> 
> Best Regards,
> Jatin

@jatin-bhateja It looks reasonable to me now. Let me run some testing, ping me in 24h for the results!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24169#issuecomment-2771465382