RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v7]

[Emanuel Peter]

On Wed, 2 Apr 2025 14:01:52 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor with checkEQWithRawBits
>
> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 60:
> 
>> 58:     private final boolean isFloatCheckWithRawBits;
>> 59:     private final HashMap<Object, Object> a2b = new HashMap<>();
>> 60:     private final HashMap<Object, Object> b2a = new HashMap<>();
> 
> Can you add a comment here what `a2b` and `b2a` means? See also some other comment further down about `a2b/b2a`, maybe you can share some docs or cross reference.

I added some documentation :)

> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 488:
> 
>> 486:         Object aPrevious = b2a.get(b);
>> 487:         if (aPrevious == null && bPrevious == null) {
>> 488:             // Record for next time.
> 
> Can you explain, maybe as comment at `checkAlreadyVisited()`, why we want to have these caches?

Added documentation :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026251090
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026252113