RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v7]

[Emanuel Peter]

On Wed, 2 Apr 2025 14:11:13 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor with checkEQWithRawBits
>
> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 109:
> 
>> 107:         Class ca = a.getClass();
>> 108:         Class cb = b.getClass();
>> 109:         if (ca != cb) {
> 
> Only seen this in my IDE: `ca` and `cb` should be `Class<?>` instead of the raw `Class` since `getClass()` returns a `Class<?>` (cannot make a suggestion since it's hidden here).

fixed

> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 124:
> 
>> 122:         switch (a) {
>> 123:             case Object[]  x -> checkEQimpl(x, (Object[])b,                 field, aParent, bParent);
>> 124:             case Byte      x -> checkEQimpl(x, ((Byte)b).byteValue(),       field, aParent, bParent);
> 
> Can't you just pass `(Byte) b` to rely on auto unboxing instead?

You are right, simplified it :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026257889
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026254841