RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v7]

Emanuel Peter epeter at openjdk.org
Thu Apr 3 06:05:52 UTC 2025


On Wed, 2 Apr 2025 14:12:59 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor with checkEQWithRawBits
>
> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 143:
> 
>> 141:             case Exception x -> checkEQimpl(x, (Exception) b,               field, aParent, bParent);
>> 142:             default -> {
>> 143:                 if (ca.getName().startsWith("jdk.incubator.vector") && ca.getName().contains("Vector")) {
> 
> Might be worth to extract this case to own methods and structure it like this to reduce the size of the method:
> 
> if (vectorClass()) {
>     checkEQForVectorAPIClass();
> } else {
>     checkEQdispatch();
> }

Refactored it :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2026266298


More information about the hotspot-compiler-dev mailing list