RFR: 8353665: RISC-V: IR verification fails in TestSubNodeFloatDoubleNegation.java [v2]
Hamlin Li
mli at openjdk.org
Mon Apr 7 12:05:12 UTC 2025
On Fri, 4 Apr 2025 13:43:43 GMT, Manuel Hässig <duke at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refine
>
> test/hotspot/jtreg/compiler/floatingpoint/TestSubNodeFloatDoubleNegation.java line 60:
>
>> 58: @IR(counts = { IRNode.SUB, "2" }, applyIfPlatform = {"riscv64", "false"})
>> 59: @IR(counts = { IRNode.SUB, "2" }, applyIfCPUFeature = {"zfh", "false"})
>> 60: @IR(counts = { IRNode.SUB, ">= 2" }, applyIfCPUFeature = {"zfh", "true"})
>
> Just a small nit: I find the following expresses the intention of the test more precisely
>
> Suggestion:
>
> @IR(counts = { IRNode.SUB_HF, "2" }, applyIfCPUFeature = {"zfh", "true"})
Make sense, fixed!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24421#discussion_r2031094485
More information about the hotspot-compiler-dev
mailing list