RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v3]
Kangcheng Xu
kxu at openjdk.org
Thu Apr 17 18:23:20 UTC 2025
> This PR refactors `PhaseIdealLoop::is_counted_loop()` into (mostly) `CountedLoopConverter::is_counted_loop()` and `CountedLoopConverter::convert()` to decouple the detection and conversion code. This enables us to try different loop configurations easily and finally convert once a counted loop is found.
>
> A nested `PhaseIdealLoop::CountedLoopConverter` class is created to handle the context, but I'm not if this is the best name or place for it. Please let me know what you think.
>
> Blocks [JDK-8336759](https://bugs.openjdk.org/browse/JDK-8336759).
Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
WIP: review followups
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24458/files
- new: https://git.openjdk.org/jdk/pull/24458/files/b72e7714..4d7738c8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24458&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24458&range=01-02
Stats: 192 lines in 2 files changed: 80 ins; 60 del; 52 mod
Patch: https://git.openjdk.org/jdk/pull/24458.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24458/head:pull/24458
PR: https://git.openjdk.org/jdk/pull/24458
More information about the hotspot-compiler-dev
mailing list