RFR: 8354284: Add more compiler test folders to tier1 runs

Marc Chevalier mchevalier at openjdk.org
Thu Apr 24 08:23:47 UTC 2025


On Wed, 23 Apr 2025 08:44:04 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

> Some folders in jtreg/compiler have been reported not to be run in any tier, while tier1 was probably intended, but the tier definition was mistakenly not updated. I've checked which folders are not referenced into `TEST.groups`.
> 
> The unmentioned ones:
> - `ccp`
> - `ciReplay`
> - `ciTypeFlow`
> - `compilercontrol`
> - `debug`
> - `oracle`
> - `predicates`
> - `print`
> - `relocations`
> - `sharedstubs`
> - `splitif`
> - `tiered`
> - `whitebox`
> 
> And those, that are not test folders:
> - `lib`
> - `patches`
> - `testlibraries`
> 
> I'm adding `ccp`, `ciTypeFlow`, `predicates`, `sharedstubs` and `splitif` to tier1.
> 
> The other folders seems to have been around for very long (since at least mid-2021). It's not clear how meaningful it'd be to add them/what the intent from them was. I've rather focused on the recently(-ish) added folders, that one forgot to put in a tier when adding it.
> 
> Feel free to tell if other folders should be included (and in which tier).
> 
> Thanks,
> Marc

Before:
duration: 1h 06m 20s; machine time: 22h 21m 08s
After:
duration: 59m 36s; machine time: 21h 27m 03s

It seems not to increase by more than the existing fluctuations.

Also, I think it's not quite as simple as this. It's rather a tradeoff between tier1 should be minimal in duration, while being maximal in coverage. A tier1 that doesn't cover some topics is not as useful. Some of these folders should have always been in tier1: they are just a more meaningful classification than stuffing everything in a generically named folder, but the group definition was mistakenly not updated back then.

This PR is adding only 39 files. There is one with custom timeout: `predicates/TestCloningWithManyDiamondsInExpression.java` with a timeout of 30. To compare with some tests in `c1` or `c2`, not excluded from tier1, with timeout up to 600.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24817#issuecomment-2826768154


More information about the hotspot-compiler-dev mailing list