RFR: 8354284: Add more compiler test folders to tier1 runs
Christian Hagedorn
chagedorn at openjdk.org
Tue Apr 29 07:53:47 UTC 2025
On Wed, 23 Apr 2025 08:44:04 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
> Some folders in jtreg/compiler have been reported not to be run in any tier, while tier1 was probably intended, but the tier definition was mistakenly not updated. I've checked which folders are not referenced into `TEST.groups`.
>
> The unmentioned ones:
> - `ccp`
> - `ciReplay`
> - `ciTypeFlow`
> - `compilercontrol`
> - `debug`
> - `oracle`
> - `predicates`
> - `print`
> - `relocations`
> - `sharedstubs`
> - `splitif`
> - `tiered`
> - `whitebox`
>
> And those, that are not test folders:
> - `lib`
> - `patches`
> - `testlibraries`
>
> I'm adding `ccp`, `ciTypeFlow`, `predicates`, `sharedstubs` and `splitif` to tier1.
>
> The other folders seems to have been around for very long (since at least mid-2021). It's not clear how meaningful it'd be to add them/what the intent from them was. I've rather focused on the recently(-ish) added folders, that one forgot to put in a tier when adding it.
>
> Feel free to tell if other folders should be included (and in which tier).
>
> Thanks,
> Marc
Looks good to me and I agree that the proposed tests should always have been in tier1 for the laid out reasons above.
> It seems not to increase by more than the existing fluctuations.
Thanks for double-checking!
> `predicates/TestCloningWithManyDiamondsInExpression.java` with a timeout of 30
A lower than standard timeout is always fine. I originally added this test which was stuck in an endless loop before the fix. I put a lower than standard timeout there because I wanted to make sure it's now finishing quickly.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24817#pullrequestreview-2802403211
More information about the hotspot-compiler-dev
mailing list