RFR: 8354520: IGV: dump contextual information [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Apr 24 08:33:50 UTC 2025
On Wed, 23 Apr 2025 10:51:27 GMT, Manuel Hässig <duke at openjdk.org> wrote:
>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/utils/IdealGraphVisualizer/README.md
>>
>> Co-authored-by: Manuel Hässig <manuel.hassig at oracle.com>
>
> src/utils/IdealGraphVisualizer/README.md line 57:
>
>> 55: The JVM provides some entry functions to dump graphs from a debugger such as
>> 56: `gdb` or `rr`, see the different variants of `igv_print` and `igv_append` in
>> 57: `compile.cpp`. In combination with the IGV network interface, these functions
>
> Suggestion:
>
> [`compile.cpp`](src/hotspot/share/opto/compile.cpp). In combination with the
> IGV network interface, these functions
Thanks for the suggestion, but what is the value of adding such a link here?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24724#discussion_r2057848401
More information about the hotspot-compiler-dev
mailing list