RFR: 8354520: IGV: dump contextual information [v2]
Manuel Hässig
duke at openjdk.org
Thu Apr 24 09:05:46 UTC 2025
On Thu, 24 Apr 2025 08:30:46 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> src/utils/IdealGraphVisualizer/README.md line 57:
>>
>>> 55: The JVM provides some entry functions to dump graphs from a debugger such as
>>> 56: `gdb` or `rr`, see the different variants of `igv_print` and `igv_append` in
>>> 57: `compile.cpp`. In combination with the IGV network interface, these functions
>>
>> Suggestion:
>>
>> [`compile.cpp`](src/hotspot/share/opto/compile.cpp). In combination with the
>> IGV network interface, these functions
>
> Thanks for the suggestion, but what is the value of adding such a link here?
I often find them helpful to find the files a readme is referring to, so I tend to add them. But it's up to you whether you like them as well :slightly_smiling_face:
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24724#discussion_r2057913177
More information about the hotspot-compiler-dev
mailing list