RFR: 8355472: Clean up x86 nativeInst after 32-bit x86 removal

[Aleksey Shipilev]

On Mon, 28 Apr 2025 08:23:25 GMT, Manuel Hässig <duke at openjdk.org> wrote:

> This PR cleans up code 32-bit x86 code in `nativeInst_x86.*` files.
> 
> Testing:
>  - [x] tier1 through tier4 on x86 plus Oracle internal testing

Looks good! I have a tiny readability suggestion. Feel free to ignore it:

src/hotspot/cpu/x86/nativeInst_x86.cpp line 305:

> 303:   // make sure code pattern is actually a mov [reg+offset], reg instruction
> 304:   u_char test_byte = *(u_char*)instruction_address();
> 305:   if (!((test_byte == lea_instruction_code) || (test_byte == mov64_instruction_code))) {

Suggestion:

  if ((test_byte != lea_instruction_code) && (test_byte != mov64_instruction_code)) {

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24911#pullrequestreview-2798506760
PR Review Comment: https://git.openjdk.org/jdk/pull/24911#discussion_r2063189018