RFR: 8354520: IGV: dump contextual information [v5]

Wed Apr 30 14:57:57 UTC 2025

On Wed, 30 Apr 2025 14:42:30 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/idealGraphPrinter.cpp line 967:
>> 
>>> 965:   if (!_current_method || !_should_send_method || node == nullptr) return;
>>> 966: 
>>> 967:   frame current = fr == nullptr ? os::current_frame() : *fr;
>> 
>> Suggestion:
>> 
>>   frame current_frame = fr == nullptr ? os::current_frame() : *fr;
>> 
>> Just to make sure there is no confusion with `_current_method`.
>> Optional, up to you.
>
> Also: what is the implication of having the `frame` object on the stack, rather than a pointer to it?

Well, never mind, I see it all over the runtime code base. Seems ok, though I'm a little uneasy about it. But not your problem, I guess ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24724#discussion_r2068832679