RFR: 8364141: Remove LockingMode related code from x86 [v2]
Fredrik Bredberg
fbredberg at openjdk.org
Tue Aug 5 12:36:02 UTC 2025
On Tue, 5 Aug 2025 06:15:21 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update one after review
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 397:
>
>> 395: // The interpreter provides two properties:
>> 396: // I1: At return-time the interpreter automatically and quietly unlocks any
>> 397: // objects acquired the current activation (frame). Recall that the
>
> Suggestion:
>
> // objects acquired in the current activation (frame). Recall that the
Fixed
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 401:
>
>> 399: // a frame.
>> 400: // I2: If a method attempts to unlock an object that is not held by the
>> 401: // the frame the interpreter throws IMSX.
>
> Suggestion:
>
> // frame the interpreter throws IMSX.
Fixed
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 409:
>
>> 407: //
>> 408: // The only other source of unbalanced locking would be JNI. The "Java Native Interface:
>> 409: // Programmer's Guide and Specification" claims that an object locked by jni_monitorenter
>
> Suggestion:
>
> // The only other source of unbalanced locking would be JNI. The "Java Native Interface
> // Specification" states that an object locked by JNI's_MonitorEnter
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26552#discussion_r2254201947
PR Review Comment: https://git.openjdk.org/jdk/pull/26552#discussion_r2254202571
PR Review Comment: https://git.openjdk.org/jdk/pull/26552#discussion_r2254203510
More information about the hotspot-compiler-dev
mailing list