RFR: 8365844: RISC-V: TestBadFormat.java fails when running without RVV [v2]

[Christian Hagedorn]

On Thu, 21 Aug 2025 06:52:07 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch? Thanks!
>> 
>> We noticed that testlibrary_tests/ir_framework/tests/TestBadFormat.java fails when running tier4 tests on p550.
>> The reason for the error is that the Vector test related to badVectorNodeSize requires RVV on riscv, otherwise the expected passing case will fail and cannot match FailCount.
>> 
>> ### Test (fastdebug)
>> - [x] Run testlibrary_tests/ir_framework/tests/TestBadFormat.java on k1/k230/sg2042
>
> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable test without RVV and fix in BadIRAnnotationsAfterTestVM

Thanks for the update and trying it out! That looks cleaner now. A small improvement suggestion but otherwise, it looks good to me.

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java line 1128:

> 1126:     @FailCount(8)
> 1127:     @IR(counts = {IRNode.LOAD_VECTOR_I, "> 0"}, applyIf = {"MaxVectorSize", ">0"})
> 1128:     @IR(counts = {IRNode.LOAD_VECTOR_I, IRNode.VECTOR_SIZE_MAX, "> 0"}, applyIf = {"MaxVectorSize", ">0"}) // valid

Maybe we can add an additional comment:
Suggestion:

    @IR(counts = {IRNode.LOAD_VECTOR_I, "> 0"}, applyIf = {"MaxVectorSize", "> 0"}) // valid, but only if MaxVectorSize > 0, otherwise, a violation is reported
    @IR(counts = {IRNode.LOAD_VECTOR_I, IRNode.VECTOR_SIZE_MAX, "> 0"}, applyIf = {"MaxVectorSize", "> 0"}) // valid, but only if MaxVectorSize > 0, otherwise, a violation is reported

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26855#pullrequestreview-3140060733
PR Review Comment: https://git.openjdk.org/jdk/pull/26855#discussion_r2290623169