RFR: 8365844: RISC-V: TestBadFormat.java fails when running without RVV [v2]

Dingli Zhang dzhang at openjdk.org
Thu Aug 21 11:04:56 UTC 2025


On Thu, 21 Aug 2025 10:33:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Enable test without RVV and fix in BadIRAnnotationsAfterTestVM
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java line 1128:
> 
>> 1126:     @FailCount(8)
>> 1127:     @IR(counts = {IRNode.LOAD_VECTOR_I, "> 0"}, applyIf = {"MaxVectorSize", ">0"})
>> 1128:     @IR(counts = {IRNode.LOAD_VECTOR_I, IRNode.VECTOR_SIZE_MAX, "> 0"}, applyIf = {"MaxVectorSize", ">0"}) // valid
> 
> Maybe we can add an additional comment:
> Suggestion:
> 
>     @IR(counts = {IRNode.LOAD_VECTOR_I, "> 0"}, applyIf = {"MaxVectorSize", "> 0"}) // valid, but only if MaxVectorSize > 0, otherwise, a violation is reported
>     @IR(counts = {IRNode.LOAD_VECTOR_I, IRNode.VECTOR_SIZE_MAX, "> 0"}, applyIf = {"MaxVectorSize", "> 0"}) // valid, but only if MaxVectorSize > 0, otherwise, a violation is reported

Thanks! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26855#discussion_r2290685442


More information about the hotspot-compiler-dev mailing list