RFR: 8365909: [REDO] Add a compilation timeout flag to catch long running compilations

Christian Hagedorn chagedorn at openjdk.org
Fri Aug 22 21:25:51 UTC 2025


On Thu, 21 Aug 2025 11:56:17 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

> This PR adds a timeout for compilation tasks based on timer signals on Linux debug builds.
> 
> This PR is a redo of #25872 with fixes for the failing test.
> 
> Testing:
>  - [x] Github Actions
>  - [x] tier1,tier2 plus internal testing on all Oracle supproted platforms
>  - [x] tier3,tier4 on linux-x64-debug
>  - [x] tier1,tier2,tier3,tier4 on linux-x64-debug with `-XX:CompileTaskTimeout=60000`

Looks good to me, too!

src/hotspot/os/linux/compilerThreadTimeout_linux.cpp line 105:

> 103:   #else
> 104:   sev._sigev_un._tid = thread->osthread()->thread_id();
> 105:   #endif // MUSL_LIBC

The `ifdef` should probably also be without indentation like the other `ifdefs`:
Suggestion:

#ifdef MUSL_LIBC
  sev.sigev_notify_thread_id = thread->osthread()->thread_id();
#else
  sev._sigev_un._tid = thread->osthread()->thread_id();
#endif // MUSL_LIBC

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26882#pullrequestreview-3146112274
PR Review Comment: https://git.openjdk.org/jdk/pull/26882#discussion_r2294770931


More information about the hotspot-compiler-dev mailing list