RFR: 8365909: [REDO] Add a compilation timeout flag to catch long running compilations [v2]

Manuel Hässig mhaessig at openjdk.org
Mon Aug 25 07:20:45 UTC 2025


On Fri, 22 Aug 2025 21:22:11 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> src/hotspot/os/linux/compilerThreadTimeout_linux.cpp line 105:
> 
>> 103:   #else
>> 104:   sev._sigev_un._tid = thread->osthread()->thread_id();
>> 105:   #endif // MUSL_LIBC
> 
> The `ifdef` should probably also be without indentation like the other `ifdefs`:
> Suggestion:
> 
> #ifdef MUSL_LIBC
>   sev.sigev_notify_thread_id = thread->osthread()->thread_id();
> #else
>   sev._sigev_un._tid = thread->osthread()->thread_id();
> #endif // MUSL_LIBC

Good catch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26882#discussion_r2297309858


More information about the hotspot-compiler-dev mailing list