RFR: 8351889: C2 crash: assertion failed: Base pointers must match (addp 344) [v3]

[Roland Westrelin]

On Mon, 24 Nov 2025 11:53:16 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8351889
>>  - verif
>>  - Merge branch 'master' into JDK-8351889
>>  - test seed
>>  - more
>>  - Merge branch 'master' into JDK-8351889
>>  - Merge branch 'master' into JDK-8351889
>>  - more
>>  - test
>>  - fix
>
> src/hotspot/share/opto/phaseX.cpp line 2085:
> 
>> 2083:   }
>> 2084:   return false;
>> 2085: }
> 
> Why not call it `verify_node_invariants_for`?
> 
> You should also assert immediately. @benoitmaillard Is about to make that change for everything: https://github.com/openjdk/jdk/pull/28295

That one is not integrated. Shouldn't I do that change only if it/when integrates?

> src/hotspot/share/opto/phaseX.hpp line 623:
> 
>> 621:     // '-XX:VerifyIterativeGVN=10000'
>> 622:     return ((VerifyIterativeGVN % 100000) / 10000) == 1;
>> 623:   }
> 
> You will need to add extra documentation to the flag. And also there is a test that uses the flag. You should adjust it to enable this bit as well.

Done in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25386#discussion_r2580416861
PR Review Comment: https://git.openjdk.org/jdk/pull/25386#discussion_r2580411292