RFR: 8351889: C2 crash: assertion failed: Base pointers must match (addp 344) [v3]

[Emanuel Peter]

On Tue, 2 Dec 2025 09:46:05 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/phaseX.cpp line 2085:
>> 
>>> 2083:   }
>>> 2084:   return false;
>>> 2085: }
>> 
>> Why not call it `verify_node_invariants_for`?
>> 
>> You should also assert immediately. @benoitmaillard Is about to make that change for everything: https://github.com/openjdk/jdk/pull/28295
>
> That one is not integrated. Shouldn't I do that change only if it/when integrates?

Right, keep it, just be informed, it may get integrated soon :)

Renaming would still be good ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25386#discussion_r2582199486