RFR: 8351889: C2 crash: assertion failed: Base pointers must match (addp 344) [v2]

[Roland Westrelin]

On Mon, 24 Nov 2025 09:46:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> > The duplication comes from loop body cloning so I'm not sure how we could prevent the duplication. We could try to common the CastPP nodes once PhaseIdealLoop::peeled_dom_test_elim() is called.
> 
> Right, that could be an option. Do you think that is worth it?

`IfNode::Ideal` looks for a dominating `If` that can replace the current `If`. It's not clear to me that that transformation can't trigger a similar failure which is why I think a fix during igvn is more robust.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25386#issuecomment-3601177439