RFR: 8370922: Template Framework Library: Float16 type and operations

Galder Zamarreño galder at openjdk.org
Fri Dec 12 15:23:37 UTC 2025


On Fri, 31 Oct 2025 22:23:28 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> We should test `Float16` with Template Framework Tests. For this, I'm now implementing:
> 
> - Template Framework Library: add `Float16Type` that represents `Float16`. Extend `Operations.java` with `Float16` operations.
> - `Verify.java`: add verification for `Float16`, and corresponding tests in `TestVerifyIncubatorVector.java`. We could have done this separately, but it is not much code and completes the pipeline from code generation through execution and finally result verification in the following two tests.
> - Adding `Float16` to `ExpressionFuzzer.java` and `TestExpressions.java`.

Looks good, just a small question about the name of the test

test/hotspot/jtreg/testlibrary_tests/verify/tests/TestVerifyIncubatorVector.java line 44:

> 42: import compiler.lib.verify.*;
> 43: 
> 44: public class TestVerifyIncubatorVector {

I have doubts about leaving the "Incubator" name in the test class name as it's temporary. Are you going to refactor the class name when API is not incubator any more? Maybe `TestVerifyVectorAPI` instead?

-------------

Changes requested by galder (Author).

PR Review: https://git.openjdk.org/jdk/pull/28095#pullrequestreview-3572147178
PR Review Comment: https://git.openjdk.org/jdk/pull/28095#discussion_r2614488442


More information about the hotspot-compiler-dev mailing list