RFR: 8370922: Template Framework Library: Float16 type and operations

Emanuel Peter epeter at openjdk.org
Fri Dec 12 17:03:52 UTC 2025


On Fri, 12 Dec 2025 14:54:23 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> We should test `Float16` with Template Framework Tests. For this, I'm now implementing:
>> 
>> - Template Framework Library: add `Float16Type` that represents `Float16`. Extend `Operations.java` with `Float16` operations.
>> - `Verify.java`: add verification for `Float16`, and corresponding tests in `TestVerifyIncubatorVector.java`. We could have done this separately, but it is not much code and completes the pipeline from code generation through execution and finally result verification in the following two tests.
>> - Adding `Float16` to `ExpressionFuzzer.java` and `TestExpressions.java`.
>
> test/hotspot/jtreg/testlibrary_tests/verify/tests/TestVerifyIncubatorVector.java line 44:
> 
>> 42: import compiler.lib.verify.*;
>> 43: 
>> 44: public class TestVerifyIncubatorVector {
> 
> I have doubts about leaving the "Incubator" name in the test class name as it's temporary. Are you going to refactor the class name when API is not incubator any more? Maybe `TestVerifyVectorAPI` instead?

Yes, I might refactor it away actually. We could also remove the special handling in verify for foreign classes. Currently I have to do the hack with reflection. I'd like to get rid of that.

This test is here for the cases where we need to include foreign, and because we need `@modules jdk.incubator.vector`. There is the other test that already exists and does not need this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28095#discussion_r2614960491


More information about the hotspot-compiler-dev mailing list