RFR: 8370922: Template Framework Library: Float16 type and operations
Benoît Maillard
bmaillard at openjdk.org
Fri Dec 12 18:38:52 UTC 2025
On Fri, 31 Oct 2025 22:23:28 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
> We should test `Float16` with Template Framework Tests. For this, I'm now implementing:
>
> - Template Framework Library: add `Float16Type` that represents `Float16`. Extend `Operations.java` with `Float16` operations.
> - `Verify.java`: add verification for `Float16`, and corresponding tests in `TestVerifyIncubatorVector.java`. We could have done this separately, but it is not much code and completes the pipeline from code generation through execution and finally result verification in the following two tests.
> - Adding `Float16` to `ExpressionFuzzer.java` and `TestExpressions.java`.
Looks good to me, nice work! I only have one question.
test/hotspot/jtreg/compiler/igvn/ExpressionFuzzer.java line 343:
> 341: // Generate expressions with any scalar numeric types.
> 342: for (CodeGenerationDataNameType type : SCALAR_NUMERIC_TYPES) {
> 343: for (int i = 0; i < 2; i++) {
What does this loop do? And why do we have only 2 iterations here, but 10 for `PRIMITIVE_TYPES`?
-------------
Marked as reviewed by bmaillard (Committer).
PR Review: https://git.openjdk.org/jdk/pull/28095#pullrequestreview-3572915843
PR Review Comment: https://git.openjdk.org/jdk/pull/28095#discussion_r2615052804
More information about the hotspot-compiler-dev
mailing list