RFR: 8370922: Template Framework Library: Float16 type and operations [v3]

Emanuel Peter epeter at openjdk.org
Mon Dec 15 07:04:38 UTC 2025


On Fri, 12 Dec 2025 14:54:23 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename test for Galder
>
> test/hotspot/jtreg/testlibrary_tests/verify/tests/TestVerifyIncubatorVector.java line 44:
> 
>> 42: import compiler.lib.verify.*;
>> 43: 
>> 44: public class TestVerifyIncubatorVector {
> 
> I have doubts about leaving the "Incubator" name in the test class name as it's temporary. Are you going to refactor the class name when API is not incubator any more? Maybe `TestVerifyVectorAPI` instead?

@galderz I now renamed it to `TestVerifyFloat16.java`, I think it is better, even if I eventually have to refactor the internals of the test we don't have to rename the test itself :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28095#discussion_r2618210641


More information about the hotspot-compiler-dev mailing list