RFR: 8373396: Min and Max Ideal missing AddNode::Ideal optimisations [v2]
Galder Zamarreño
galder at openjdk.org
Mon Dec 15 08:03:47 UTC 2025
> `MaxI` and `MinI` are missing `AddNode::Ideal` optimizations. These optimizations include commutation, flattening, pushing constants...etc. The PR changes `MaxINode::Ideal` and `MinINode::Ideal` to call `AddNode::Ideal`. Long versions already call `AddNode::Ideal` so nothing to change there.
>
> The PR also includes a template framework generated test (cc @eme64) that verifies that all of `AddNode::Ideal` optimizations now apply correctly for min/max for longs and ints. Long tests have been added to validate that both ints and longs produce the same results.
>
> Fixing this issue indirectly fixes `compiler/codegen/TestBooleanVect.java` when run with `-XX:VerifyIterativeGVN=1110`, which was failing due to `min` not having one of those optimisations. However, this PR does not make changes to `PhaseIterGVN::verify_Identity_for` because there are additional failures observed with min/max for integers in JDK-8373134. Therefore, changes there will in the PR for JDK-8373134 instead.
>
> If you look at `PhaseIterGVN::verify_Ideal_for`, it contains. This looks like it could be removed in this PR as it looks like they were quite likely disabled due to the issue here. However, it's unclear what test was failing here (@eme64 ?):
>
>
> // MinINode::Ideal
> // Did not investigate, but there are some patterns that might
> // need more notification.
> case Op_MinI:
> case Op_MaxI: // preemptively removed it as well.
> return false;
>
>
> I've run tier1-3 tests on linux/x64 and they passed.
Galder Zamarreño has updated the pull request incrementally with six additional commits since the last revision:
- Remove MinI/MaxI exceptions from verify_Ideal_for
- Iterate over enum values instead
- Refactor to MaxNode::IdealI
- Remove variables
- Use ${test.main.class}
- Move to compiler.igvn package
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28770/files
- new: https://git.openjdk.org/jdk/pull/28770/files/2e241115..1ae30815
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28770&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28770&range=00-01
Stats: 308 lines in 4 files changed: 145 ins; 163 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/28770.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28770/head:pull/28770
PR: https://git.openjdk.org/jdk/pull/28770
More information about the hotspot-compiler-dev
mailing list