RFR: 8373396: Min and Max Ideal missing AddNode::Ideal optimisations
Galder Zamarreño
galder at openjdk.org
Tue Dec 16 11:57:57 UTC 2025
On Fri, 12 Dec 2025 17:14:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> @TobiHartmann Thanks for the review!
>>
>> @eme64 Thanks also for the review. Can you please also clarify what I said about potentially changing `PhaseIterGVN::verify_Ideal_for` in the description?
>
>> @TobiHartmann Thanks for the review!
>>
>> @eme64 Thanks also for the review. Can you please also clarify what I said about potentially changing `PhaseIterGVN::verify_Ideal_for` in the description?
>
> I don't remember. Try enabling the verification, and see if you find any test that fails. If not: great, maybe you fixed it! If it still fails, it would be nice if you added more info, but not neccessary.
>
> I don't remember because there were eventually too many cases and I stopped reporting which had failed.
@eme64 Roland provided the 2nd review so you can start your internal testing.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28770#issuecomment-3660156041
More information about the hotspot-compiler-dev
mailing list