RFR: 8373525: C2: assert(_base == Long) failed: Not a Long [v2]

[Damon Fenacci]

On Fri, 19 Dec 2025 14:41:03 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/hotspot/jtreg/compiler/loopopts/TestValidTypeInOverflowProtection.java
>>    
>>    Co-authored-by: Manuel Hässig <manuel at haessig.org>
>>  - JDK-8373525: remove test requires
>
> test/hotspot/jtreg/compiler/loopopts/TestValidTypeInOverflowProtection.java line 28:
> 
>> 26:  * @bug 8373525
>> 27:  * @summary Test for the check of a valid type (long) for the input variable of overflow protection
>> 28:  * @requires vm.debug == true & vm.compiler2.enabled
> 
> Is this requires needed? I guess it is needed to reproduce the failure, but does this test fail on a product build? Running it in more scenarios should provide for some more coverage.

Thanks for the comments @mhaessig!
Right! Removed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28920#discussion_r2635392737