RFR: 8374078: C2_MacroAssembler::verify_int_in_range has incorrect early return condition
Vladimir Kozlov
kvn at openjdk.org
Fri Dec 19 18:15:51 UTC 2025
On Fri, 19 Dec 2025 18:04:08 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Can this be new Type's check functions with comments explaining why `t == Type::INT` is not true any more?
>
> @vnkozlov I don't think it is a good idea. The check is like that specifically because it only cares about `_lo` and `_hi` at the moment. So it seems not to be a property of the `Type`. Furthermore, these tests should take into consideration and emit code to verify other properties of the `Type` in the future anyway.
@merykitty Then you need to add comment to each place you modified. Otherwise someone later could try to revert it back without understanding it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28916#issuecomment-3676043298
More information about the hotspot-compiler-dev
mailing list