RFR: 8374078: C2_MacroAssembler::verify_int_in_range has incorrect early return condition
Quan Anh Mai
qamai at openjdk.org
Fri Dec 19 18:32:14 UTC 2025
On Fri, 19 Dec 2025 18:12:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> @vnkozlov I don't think it is a good idea. The check is like that specifically because it only cares about `_lo` and `_hi` at the moment. So it seems not to be a property of the `Type`. Furthermore, these tests should take into consideration and emit code to verify other properties of the `Type` in the future anyway.
>
> @merykitty Then you need to add comment to each place you modified. Otherwise someone later could try to revert it back without understanding it.
@vnkozlov If you insist, then I'll do it, but reverting it back makes no sense given a `TypeInt` has 6 properties and this test only checks for 2 of them.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28916#issuecomment-3676089805
More information about the hotspot-compiler-dev
mailing list