RFR: 8341976: C2: use_mem_state != load->find_exact_control(load->in(0)) assert failure [v2]

Roland Westrelin roland at openjdk.org
Fri Feb 7 08:45:35 UTC 2025


On Thu, 6 Feb 2025 11:28:05 GMT, Galder ZamarreƱo <galder at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/macroArrayCopy.cpp line 831:
> 
>> 829:     insert_mem_bar(ctrl, &out_mem, Op_MemBarStoreStore, Compile::AliasIdxBot);
>> 830:   } else {
>> 831:     int alias_idx = Compile::AliasIdxBot;
> 
> Minor thing, `alias_idx` is already defined in the method with a different type. Would it make sense to use a different name here?
> 
> Earlier definition:
> 
> uint alias_idx = C->get_alias_index(adr_type);

Good catch. I renamed `alias_idx`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23465#discussion_r1946160388


More information about the hotspot-compiler-dev mailing list