RFR: 8349727: [PPC] C1: Improve Class.isInstance intrinsic [v3]
Martin Doerr
mdoerr at openjdk.org
Wed Feb 19 16:27:55 UTC 2025
On Wed, 19 Feb 2025 15:24:02 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Unroll repne_scan loop for better performance.
>
> src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp line 2845:
>
>> 2843: if (dest == Runtime1::entry_for(C1StubId::register_finalizer_id) ||
>> 2844: dest == Runtime1::entry_for(C1StubId::new_multi_array_id ) ||
>> 2845: dest == Runtime1::entry_for(C1StubId::is_instance_of_id )) {
>
> Should there be an assertion that `dest` is in the CodeCache?
> Or even use that check as condition to emit the optimized call?
I've added the assertion. I prefer having the special stubs listed explicitly. I hope that there will not be many more. Otherwise, we could still change it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23602#discussion_r1961998128
More information about the hotspot-compiler-dev
mailing list