RFR: 8349727: [PPC] C1: Improve Class.isInstance intrinsic [v3]

[Richard Reingruber]

On Wed, 19 Feb 2025 16:24:57 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp line 2845:
>> 
>>> 2843:   if (dest == Runtime1::entry_for(C1StubId::register_finalizer_id) ||
>>> 2844:       dest == Runtime1::entry_for(C1StubId::new_multi_array_id   ) ||
>>> 2845:       dest == Runtime1::entry_for(C1StubId::is_instance_of_id    )) {
>> 
>> Should there be an assertion that `dest` is in the CodeCache?
>> Or even use that check as condition to emit the optimized call?
>
> I've added the assertion. I prefer having the special stubs listed explicitly. I hope that there will not be many more. Otherwise, we could still change it.

Yes, maybe that's better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23602#discussion_r1962053749