RFR: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges [v2]

[Daniel Lundén]

On Tue, 25 Feb 2025 11:23:28 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove test that no longer reproduces the issue
>
> src/hotspot/share/opto/cfgnode.cpp line 2437:
> 
>> 2435:       worklist.push(this);
>> 2436:       visited.set(this->_idx);
>> 2437:       auto add_to_worklist = [&](Node* input) {
> 
> Suggestion: rename to `maybe_add_to_worklist` to stress that it is a conditional addition.

Sure, now fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23691#discussion_r1969942203