RFR: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges [v2]

[Daniel Lundén]

On Tue, 25 Feb 2025 11:22:15 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove test that no longer reproduces the issue
>
> src/hotspot/share/opto/cfgnode.cpp line 1120:
> 
>> 1118:   }
>> 1119:   Compile *C = igvn->C;
>> 1120:   ResourceMark rm;
> 
> I would suggest leaving this change to a separate (possible starter) RFE.

The problem with leaving this to a separate RFE is that the idealization changes in this changeset trigger a memory consumption bug related to this missing `ResourceMark`. Specifically, without the `ResourceMark` we now hit the 1GB memory limit in quite a number of tests. Therefore, it seems counterproductive to not fix as part of this changeset?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23691#discussion_r1969958922