RFR: 8333393: PhaseCFG::insert_anti_dependences can fail to raise LCAs and to add necessary anti-dependence edges [v2]

[Roberto Castañeda Lozano]

On Tue, 25 Feb 2025 14:59:12 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> src/hotspot/share/opto/cfgnode.cpp line 1120:
>> 
>>> 1118:   }
>>> 1119:   Compile *C = igvn->C;
>>> 1120:   ResourceMark rm;
>> 
>> I would suggest leaving this change to a separate (possible starter) RFE.
>
> The problem with leaving this to a separate RFE is that the idealization changes in this changeset trigger a memory consumption bug related to this missing `ResourceMark`. Specifically, without the `ResourceMark` we now hit the 1GB memory limit in quite a number of tests. Therefore, it seems counterproductive to not fix as part of this changeset?

Fair enough, I was not aware of the interaction. Please leave this conversation unresolved as additional insight for future reviewers.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23691#discussion_r1970243106