RFR: 8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp [v3]
Hamlin Li
mli at openjdk.org
Fri Feb 28 12:41:54 UTC 2025
On Fri, 28 Feb 2025 12:13:15 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove unnecessary effect
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2140:
>
>> 2138: assert_different_registers(dst, src1);
>> 2139: assert_different_registers(dst, src2);
>> 2140:
>
> Ah, Seems I missed this in my last PR :-) Looks reasonable to me.
> But we should remove the `TEMP_DEF dst` effect from the related match rule in riscv.ad file where it is called.
> One example: https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L7290
Yes, will do it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23842#discussion_r1975344776
More information about the hotspot-compiler-dev
mailing list