RFR: 8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp [v3]

Fei Yang fyang at openjdk.org
Fri Feb 28 12:48:59 UTC 2025


On Fri, 28 Feb 2025 12:38:43 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2140:
>> 
>>> 2138:   assert_different_registers(dst, src1);
>>> 2139:   assert_different_registers(dst, src2);
>>> 2140: 
>> 
>> Ah, Seems I missed this in my last PR :-)  Looks reasonable to me.
>> But we should remove the `TEMP_DEF dst` effect from the related match rule in riscv.ad file where it is called.
>> One example: https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L7290
>
> Yes, will do it.

Thanks. But I think you should keep `KILL cr` effect as this assember routine modifies `t1` thus kills `cr`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23842#discussion_r1975352939


More information about the hotspot-compiler-dev mailing list