RFR: 8342676: Unsigned Vector Min / Max transforms [v2]

[Jatin Bhateja]

On Wed, 8 Jan 2025 09:10:12 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Updating copyright year of modified files
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8342676
>>  - Update IR transforms and tests
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8342676
>>  - 8342676: Unsigned Vector Min / Max transforms
>
> src/hotspot/share/opto/vectornode.hpp line 622:
> 
>> 620:   virtual uint hash() const {
>> 621:     return (uintptr_t)in(1) + (uintptr_t)in(2) + Opcode();
>> 622:   }
> 
> Can you explain why you do this instead of `Node::hash`?
> I think you do it so that you get the same hash if you swap the operands.
> I suggest you leave a comment in the code.

I think it will be better to schedule this patch after https://github.com/openjdk/jdk/pull/22863
where these nodes are marked at commutative operations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21604#discussion_r1907048571