RFR: 8342676: Unsigned Vector Min / Max transforms [v2]

[Emanuel Peter]

On Wed, 8 Jan 2025 11:37:32 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 622:
>> 
>>> 620:   virtual uint hash() const {
>>> 621:     return (uintptr_t)in(1) + (uintptr_t)in(2) + Opcode();
>>> 622:   }
>> 
>> Can you explain why you do this instead of `Node::hash`?
>> I think you do it so that you get the same hash if you swap the operands.
>> I suggest you leave a comment in the code.
>
> I think it will be better to schedule this patch after https://github.com/openjdk/jdk/pull/22863
> where these nodes are marked as commutative operations.

Ah ok, I will put that one in my review queue! There is lots that have accumulated over the last 2 weeks 🙈

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21604#discussion_r1907125031